Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist dark background setting too #348

Open
XhmikosR opened this issue Oct 14, 2021 · 4 comments · May be fixed by #415
Open

Persist dark background setting too #348

XhmikosR opened this issue Oct 14, 2021 · 4 comments · May be fixed by #415
Labels
enhancement help wanted

Comments

@XhmikosR
Copy link
Collaborator

No description provided.

@BarokDG
Copy link

BarokDG commented Nov 4, 2022

Can you give me a better description of this @XhmikosR?

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Nov 4, 2022 •
edited
Loading

The toggle background setting is not saved in the session like the SVGO config settings, thus it's not persistent.

@BarokDG
Copy link

BarokDG commented Nov 4, 2022

Okay. I looked inside the indexedDB and I believe all I have to do is add another key-value pair, inside the settings field, to track the state of the floating action button that has a bucket icon on it. Correct?

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Nov 5, 2022

Yup, in theory that's what's needed.

@BarokDG BarokDG linked a pull request Nov 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save bg fill state to storage BarokDG/svgomg
2 participants
@XhmikosR @BarokDG