Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Switch to use OTEL's http/grpc servers #6026

Open
yurishkuro opened this issue Sep 28, 2024 · 5 comments · May be fixed by #6055
Open

[query] Switch to use OTEL's http/grpc servers #6026

yurishkuro opened this issue Sep 28, 2024 · 5 comments · May be fixed by #6055
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

In #6023 we changed http/grpc servers in the query service to be configured via OTEL config structs, but we still have a custom implementation for creating the servers. We should fully switch to OTEL's implementations. This will be another breaking change because in OTEL the servers cannot share the same port, which is today supported in the query service via cmux.
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Sep 28, 2024
@yurishkuro yurishkuro mentioned this issue Sep 28, 2024
Closed
6 tasks
@dosubot dosubot bot added area/otel changelog:breaking-change Change that is breaking public APIs or established behavior labels Sep 28, 2024
@Garvit-77
Copy link

Hello @yurishkuro
I would like to give it a try

@yurishkuro
Copy link
Member Author

@Garvit-77 go ahead

@mahadzaryab1
Copy link
Collaborator

@yurishkuro what should be passed in for component.Host in the ToSever method?

@yurishkuro
Copy link
Member Author

When running in v2 mode we have the real host available in the extension. For v1 it's ok to pass noop, but we need to make sure that we would still get the metrics from these endpoints as we get today.

@mahadzaryab1 mahadzaryab1 linked a pull request Oct 5, 2024 that will close this issue
Draft
4 tasks
@Garvit-77
Copy link

`type Server struct {
querySvc *querysvc.QueryService
queryOptions *QueryOptions

conn          net.Listener
grpcConn      net.Listener
httpConn      net.Listener
grpcServer    *grpc.Server
httpServer    *httpServer
separatePorts bool
bgFinished    sync.WaitGroup
telemetery.Setting

}`
As we're trying to completely switch to OTEL can't we change or remove the Server Struct ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
Jaeger V2
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] [query] use otel's implementation for constructing http and grpc servers mahadzaryab1/jaeger
3 participants
@yurishkuro @mahadzaryab1 @Garvit-77