Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite broken #61

Open
jaeandersson opened this issue Sep 18, 2015 · 5 comments
Open

Test suite broken #61

jaeandersson opened this issue Sep 18, 2015 · 5 comments
Labels

Comments

@jaeandersson
Copy link
Owner

The test suite got (more) broken in one of the more recent commits.

@jaeandersson
Copy link
Owner Author

What is causing this is that there is no good way of disabling all the tests that are known not to work. At least in my understanding. For all practical purposes, the test suite has always been broken for MATLAB. Sometimes changes to the module will cause some tests to fail more violently than before (e.g. crashing MATLAB), but that should not be a reason to hold back a commit.

@jaeandersson
Copy link
Owner Author

starting a git bisect

@jaeandersson
Copy link
Owner Author

The violently failing example appesrs to be dynamic_cast

@jaeandersson
Copy link
Owner Author

jaeandersson@jaeandersson-VirtualBox:~/dev/swig$ git bisect log
git bisect start

bad: [98ed108] Merge branch 'dcb210-matlab' into matlab

git bisect bad 98ed108

good: [8e13c91] Revert "[MATLAB] issue #47: Fixes 'clear all' bug"

git bisect good 8e13c91

good: [8f4101f] [MATLAB] issue #44: Enforced modulenameMATLAB_wrap naming convension for compiled mex function

git bisect good 8f4101f

bad: [b2aee0e] [MATLAB] issue #44: Removed unused variables

git bisect bad b2aee0e

bad: [f1a0155] [MATLAB] issue #44: Removed setup script functionality Usually not needed and when needed, any script can be called from the init function

git bisect bad f1a0155

bad: [90e792f] [MATLAB] issue #44: Refactored initialization of modules

git bisect bad 90e792f

good: [72c5ccb] [MATLAB] issue #44: Added option for specifying mex-function infix

git bisect good 72c5ccb

first bad commit: [90e792f] [MATLAB] issue #44: Refactored initialization of modules

@KrisThielemans
Copy link

This is outdated, certainly after #96. I suggest to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants