Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get mergesort running with the test-suite #113

Closed
rrnewton opened this issue Jun 24, 2015 · 4 comments
Closed

Get mergesort running with the test-suite #113

rrnewton opened this issue Jun 24, 2015 · 4 comments

Comments

@rrnewton
Copy link
Member

After everything is green on our CI unit testing, mergesort should really be included as a test.

Currently it has its own cabal file. But now that cabal has "benchmark" sections, it could be included as a benchmark of the top-level par-transformers cabal file.
@osa1
Copy link
Member

osa1 commented Jul 4, 2015

I just implemented QuickCheck tests for this: 77a6a36#diff-1e8a7ec63946a27fbec1217374f65e69R26 unfortunately it's failing all the time. Looks like I have some debugging to do...

@osa1
Copy link
Member

osa1 commented Jul 5, 2015

I fixed couple of bugs and implemented some tests(including QuickCheck test for sorting random vectors). Now only problem is making it running in travis.

@osa1
Copy link
Member

osa1 commented Jul 6, 2015

par-mergesort is now ready but see #114.

@osa1
Copy link
Member

osa1 commented Jul 8, 2015

This is done, Travis is green now.

@osa1 osa1 closed this as completed Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrnewton @osa1