Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document item names for saved passwords and OAuth tokens in password managers #453

Open
AliveDevil opened this issue Nov 29, 2023 · 3 comments

Comments

@AliveDevil
Copy link
Contributor

AliveDevil commented Nov 29, 2023

With 1 there is now a non-zero chance, that support is required when an OAuth token is falsely configured (or should be deleted).

This changes the preferred format for Credential Manager entries from "app:Protocol" to "app:OAuthClientId".

Footnotes

  1. Save OAuth tokens with port number, scheme and hostname from token URL. cyberduck#15393

@dkocher
Copy link
Contributor

dkocher commented Apr 9, 2024

I don't see this requires documentation as there is a fallback implemented 1 for the deprecated format.

Footnotes

  1. https://github.com/iterate-ch/cyberduck/pull/15393/files#diff-1920b3f5f29d4ad7bfc6e3586784e7fd8356c7e4722264e23ba7ddcad4fa42d2R253

@dkocher dkocher closed this as completed Apr 9, 2024
@AliveDevil
Copy link
Contributor Author

The fallback doesn’t affect support cases, where users are directed to delete saved credentials for an OAuth Id.

thus support isn’t „delete onedrive“ but „delete 'id'“. The oauth ids used in this scheme should be added to docs, so that support doesn’t have to look them up every time in the default profiles - or users can use that information independently for troubleshooting.

@dkocher
Copy link
Contributor

dkocher commented Apr 9, 2024

The fallback doesn’t affect support cases, where users are directed to delete saved credentials for an OAuth Id.

thus support isn’t „delete onedrive“ but „delete 'id'“. The oauth ids used in this scheme should be added to docs, so that support doesn’t have to look them up every time in the default profiles - or users can use that information independently for troubleshooting.

You say we should document in general the naming schemes used to save credentials in the keychain and credentials manager.

@dkocher dkocher reopened this Apr 9, 2024
@dkocher dkocher changed the title Add OAuthClient Ids to troubleshooting Document item names for saved passwords and OAuth tokens in password managers Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants