-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.binding
deprecation
#89
Comments
I've thought about this problem and I think it's possible to avoid relying on
I think that it is possible to lift the current What's interesting is that the 2 highest levels can be implemented together. Instead of returning the wrapper function to the user, set it on the |
Node started to deprecate
process.binding
: https://nodejs.org/dist/latest-v11.x/docs/api/deprecations.html#deprecations_dep0111_process_bindingThis function is used by spawn-wrap to patch
spawnSync
.It is possible to avoid patching the internals at the top level by creating a wrapped
spawn
function. The main issue is caused by processes deep in the process tree: spawn-wrap tries to hook into user-code spawning processes and we cannot change it so we still have to patch the internals.There is an open Node issue discussing the issue: nodejs/node#27344
/cc @isaacs @bcoe @coreyfarrell
The text was updated successfully, but these errors were encountered: