Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Add GitHub Actions workflow for integration testing #2425

Open
1 task done
stevehipwell opened this issue Oct 14, 2024 · 3 comments
Open
1 task done

[MAINT]: Add GitHub Actions workflow for integration testing #2425

stevehipwell opened this issue Oct 14, 2024 · 3 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@stevehipwell
Copy link
Contributor

Describe the need

When pushing a change to the code I'd like the integration tests to be able to be run. This doesn't have to be automatic as there are a number of models which could be applied to stop integration credentials being abused.

  • Auto-run all actions (DON'T DO THIS)
  • Auto-run actions from repeat contributors (DON'T DO THIS)
  • Auto-run actions from organisation members
    • Put integration test credentials behind an environment and require approval to run

I'd be happy to contribute the code to do this.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@stevehipwell stevehipwell added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Oct 14, 2024
@nickfloyd nickfloyd added Type: Feature New feature or request Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Oct 17, 2024
@nickfloyd
Copy link
Contributor

@stevehipwell Thanks for the thoughts and input here! ❤

If you're up for it, this idea would be really great to see in code so that we can get a more clear picture of your thoughts here. I've also added the up for grabs label just incase others are up for working on this as well.

@stevehipwell
Copy link
Contributor Author

@nickfloyd I was working from a memory that there weren't automated tests in GH Actions and from the fact that my PRs never get automated tests. However I just checked out what's there and I can see automated tests for branches with a test/ prefix and for PRs labeled in a specific way; but they seem to be broken? Do you have more context on this?

@stevehipwell
Copy link
Contributor Author

OK, I can see what the issue is. I'll have a go at fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

No branches or pull requests

2 participants