Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add support for allowing force pushes for specified people, teams, apps #2392

Open
1 task done
jdatx opened this issue Sep 18, 2024 · 3 comments
Open
1 task done
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@jdatx
Copy link

jdatx commented Sep 18, 2024

Describe the need

I'm using semantic versioning and this requires force pushes. I've got a github app that I'd like to allow force pushes for this. When I configure this in the gui, works fine.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jdatx jdatx added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Sep 18, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Sep 23, 2024
@stevehipwell
Copy link
Contributor

@jdatx are you referring to the ability to specify an app in a github_repository_ruleset as a bypass actor? If so doesn't this already work with actor_type = "Integration"?

@jdatx
Copy link
Author

jdatx commented Oct 10, 2024

Thanks for getting to this it's appreciated.

I was talking about the github_branch_protection resource.

I'll have to reproduce it but I don't recall why the github_repository_ruleset didn't work for my case

@stevehipwell
Copy link
Contributor

@jdatx I'm not affiliated with this repo, I'm just an end user.

It looks like branch protection is still supported by GH (under the classic branch protection rule name), but if I were you I'd look at using a ruleset instead. I'm not aware of any use cases not supported by a ruleset, and since they were supported in the GH TF provider they've been made to work (the original implementation was pretty much unusable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants