Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behaviour for conflicts #83

Open
pazembrz opened this issue Jul 29, 2020 · 1 comment
Open

Change default behaviour for conflicts #83

pazembrz opened this issue Jul 29, 2020 · 1 comment

Comments

@pazembrz
Copy link
Contributor

pazembrz commented Jul 29, 2020

All conflicts should be displayed as changes form head. For conflicts which do not have separate configuration If there is conflict on update, then HEAD value should be in merged and update should be put as conflict. So when curator reject all conflicts only HEAD values should be left. This will require to set default fallback conflict strategy to KEEP_HEAD.
All conflicts which we are ignoring (ones from conflict_filters) should stay with HEAD values if they are not configured differently.

@michamos
Copy link
Contributor

I don't think you need to set the default to KEEP_HEAD. It can stay as it is, but non-ignored conflicts (those not in conflict_filters) should have KEEP_HEAD always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants