diff --git a/internal/mithril-metric/src/metric.rs b/internal/mithril-metric/src/metric.rs index 462a5c0f79..24ea8680af 100644 --- a/internal/mithril-metric/src/metric.rs +++ b/internal/mithril-metric/src/metric.rs @@ -86,19 +86,15 @@ impl MetricGauge { } /// Record a value in the gauge. - pub fn record + Copy>(&self, value: T) { - debug!( - self.logger, - "Set '{}' gauge value to {}", - self.name, - value.into() - ); - self.gauge.set(value.into()); + pub fn record>(&self, value: T) { + let value = value.into(); + debug!(self.logger, "Set '{}' gauge value to {}", self.name, value); + self.gauge.set(value); } /// Get the gauge value. pub fn get(&self) -> f64 { - self.gauge.get().round() + self.gauge.get() } fn create_metric_gauge(name: &MetricName, help: &str) -> StdResult { @@ -142,6 +138,6 @@ mod tests { assert_eq!(metric.get(), 0.0); metric.record(12.3); - assert_eq!(metric.get(), 12.0); + assert_eq!(metric.get(), 12.3); } } diff --git a/internal/mithril-metric/src/server.rs b/internal/mithril-metric/src/server.rs index 1c63031c63..c9ab4baabe 100644 --- a/internal/mithril-metric/src/server.rs +++ b/internal/mithril-metric/src/server.rs @@ -14,7 +14,7 @@ use mithril_common::logging::LoggerExtensions; use mithril_common::StdResult; /// Metrics service exporter gives the possibility of exporting metrics. -pub trait MetricsServiceExporter { +pub trait MetricsServiceExporter: Send + Sync { /// Export metrics. fn export_metrics(&self) -> StdResult; } @@ -38,19 +38,19 @@ impl IntoResponse for MetricsServerError { } /// The MetricsServer is responsible for exposing the metrics of the signer. -pub struct MetricsServer { +pub struct MetricsServer { server_port: u16, server_ip: String, metrics_service: Arc, logger: Logger, } -struct RouterState { +struct RouterState { metrics_service: Arc, logger: Logger, } -impl MetricsServer { +impl MetricsServer { /// Create a new MetricsServer instance. pub fn new(server_ip: &str, server_port: u16, metrics_service: Arc, logger: Logger) -> Self { Self { diff --git a/mithril-signer/src/metrics/service.rs b/mithril-signer/src/metrics/service.rs index e44326455e..651534d92f 100644 --- a/mithril-signer/src/metrics/service.rs +++ b/mithril-signer/src/metrics/service.rs @@ -30,7 +30,6 @@ build_metrics_service!( "mithril_signer_signature_registration_success_last_epoch", "Latest epoch at which signature successfully registered on a Mithril signer node" ), - // Runtime cycle metrics runtime_cycle_success_since_startup_counter:MetricCounter( "mithril_signer_runtime_cycle_success_since_startup", "Number of successful runtime cycles since startup on a Mithril signer node"