You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The definition for updating a System Property requires that the key of the property is provided both in the path, and in the PUT body. This is appears to only be used for checking that the user entered the value correctly twice.
To retain the restful interface, the property key makes sense to be on the path, which leaves only the property value in the body. This breaks the natural Entity pattern, which we've retained elsewhere (e.g. updating a group, where the name is both in the path and the body).
This feels "awkward" to use, but also happy to accept a close/wontfix if the consistency of pattern & usage is more important.
The text was updated successfully, but these errors were encountered:
I've seen the same pattern used elsewhere (group names / roster entities, I think). I agree that it's awkward. Retaining backwards compatibility is important though (although silently ignoring something that was previously required might still be considered 'compatible'?)
The definition for updating a System Property requires that the key of the property is provided both in the path, and in the PUT body. This is appears to only be used for checking that the user entered the value correctly twice.
To retain the restful interface, the property key makes sense to be on the path, which leaves only the property value in the body. This breaks the natural Entity pattern, which we've retained elsewhere (e.g. updating a group, where the name is both in the path and the body).
This feels "awkward" to use, but also happy to accept a close/wontfix if the consistency of pattern & usage is more important.
The text was updated successfully, but these errors were encountered: