Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System Property endpoint requires keyname twice #81

Open
Fishbowler opened this issue Jan 13, 2022 · 1 comment
Open

Update System Property endpoint requires keyname twice #81

Fishbowler opened this issue Jan 13, 2022 · 1 comment

Comments

@Fishbowler
Copy link
Member

The definition for updating a System Property requires that the key of the property is provided both in the path, and in the PUT body. This is appears to only be used for checking that the user entered the value correctly twice.

To retain the restful interface, the property key makes sense to be on the path, which leaves only the property value in the body. This breaks the natural Entity pattern, which we've retained elsewhere (e.g. updating a group, where the name is both in the path and the body).

This feels "awkward" to use, but also happy to accept a close/wontfix if the consistency of pattern & usage is more important.

@guusdk
Copy link
Member

guusdk commented Jan 19, 2022

I've seen the same pattern used elsewhere (group names / roster entities, I think). I agree that it's awkward. Retaining backwards compatibility is important though (although silently ignoring something that was previously required might still be considered 'compatible'?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants