Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculation of var_lss in true continuum problem #927

Open
p-slash opened this issue Sep 6, 2022 · 1 comment
Open

Recalculation of var_lss in true continuum problem #927

p-slash opened this issue Sep 6, 2022 · 1 comment

Comments

@p-slash
Copy link
Contributor

p-slash commented Sep 6, 2022

True continuum analysis recalculates var_lss from pixel statistics in the following lines. It is a necessary step in the current framework. However, it is also problematic when the statistics are low. Example below for negative var_lss in true continuum analysis.
Maybe we can introduce a fail-safe such as replace only if estimated var_lss is within 50% of given var_lss. Thoughts? @iprafols @Waelthus and people working on true continuum analysis.

# the might be some small changes in the var_lss compared to the read
# values due to some smoothing of the forests
# thus, we recompute it from the actual deltas
self.compute_var_lss(forests)
# note that this does not change the output deltas but might slightly
# affect the mean continuum so we have to compute it after updating
# var_lss

Screen Shot 2022-09-06 at 6 28 48 PM

@iprafols
Copy link
Collaborator

seems reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants