Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of read_objects and read_deltas in picca_xcf #805

Open
andreufont opened this issue Oct 1, 2021 · 1 comment
Open

Swap order of read_objects and read_deltas in picca_xcf #805

andreufont opened this issue Oct 1, 2021 · 1 comment

Comments

@andreufont
Copy link
Contributor

In the DR16 analysis we would first read the deltas, and used (zmin,zmax) from the deltas and (rpmax,rpmin) to set the relevant redshift range for quasars.

However, for some reason the current master branch has swapped these calls, and now we first read the objects.

Probably related to this, now the default values of z-min-obj and z-max-obj are set to (0, 10) while they were used to be None (to set them automatically based on zmin,zmax in deltas).

In the current branch, one keeps all quasars in the catalog, unless you specify by hand the redshift range. I would be in favour to going back to the previous setup.

@iprafols , @Waelthus, @alxogm - do you remember why this was changed?

@iprafols
Copy link
Collaborator

iprafols commented Oct 1, 2021

Nope, no idea when/why this was changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants