constant file

[londumas]

Searching for grep "1215\." -ri *, I get what follows.
In a same way, the optical depth parameters are hard codded:

LyaCoLoRe/py/lya_mock_functions.py

Line 39 in 1b1b03d

A = 0.374*pow((1+z)/4.0,5.10)

so are the metal ones, ...

It would be very useful, to have a constants.py where all of these values are feed into.
What do you think? Of curse it is not at the top of the list.

notebooks/old_read_colore.ipynb:    "wavelength = 1215.67*(1+z)\n",
notebooks/old_read_colore.ipynb:    "plt.xlim(1215.67*(1+2),1.01*max(wavelength))\n",
notebooks/plot_processed_files.ipynb:    "lya = 1215.67"
notebooks/plot_processed_files.ipynb:    "lya=1215.67\n",
old_examples/picca_to_desisim.py:z = wave/1215.67-1.0
old_examples/cf1d_v2.py:lya = 1215.67
old_examples/read_skewers_lya.py:wavelength = 1215.67*(1+z)
old_examples/read_skewers_lya.py:plt.xlim(1215.67*(1+2),1.01*max(wavelength))
old_examples/plot_processed_files.py:lya=1215.67
old_examples/new_format.py:z = wave/1215.67-1.0
old_examples/stats_processed_files.py:    lya=1215.67
old_examples/cf1d.py:lya = 1215.67
old_examples/plot_mean_var.py:lya = 1215.67
old_examples/test_rest_frame_transmission.py:            if z[i]>(3550./1215.67 - 1):
old_examples/test_rest_frame_transmission.py:        plt.axvline(x=1215.67,c=[0.5,0.5,0.5])
old_examples/xcf1d.py:lya = 1215.67
old_examples/make_picca_master.py:#lya = 1215.67
old_examples/check_deltas.py:    colore_ivars = functions.make_IVAR_rows(1215.67,Z_QSO,LOGLAM_MAP,N_qso,N_cells)
old_notebooks/tune_flux.ipynb:    "lya=1215.67"
old_notebooks/test_RSD.ipynb:    "lya = 1215.67"
old_notebooks/test_thermal_RSD.ipynb:    "lya = 1215.67"
py/utils.py:lya_rest = 1215.67
scripts/iminuit_tuning.py:lya = 1215.67

[jfarr03]

@londumas I think all of the above bar py/utils.py are old examples. The instance in py/utils.py is the one that is used globally in the production of new realisations (i.e. at the start of each script, lya = utils.lya_rest is defined). These will all be cleared out in due course!

A constants.py file would be nice, though is it necessary if there's only 1 constant? I guess it could have all of the metal line wavelengths as well?

[londumas]

@jfarr03, even with one constant it is useful. But there are more than 1 I bet: the bias of QSo, the bias of DLA, the optical depth parameters, ...

[londumas]

And indeed the metal lines also.