Gaussian Probe optimization #28872

maxnezdyur · 2024-10-17T14:38:49Z

closes #28871

moosebuild · 2024-10-17T17:47:22Z

Job Documentation, step Docs: sync website on 8aa6266 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2024-10-17T22:01:39Z

Job Coverage, step Generate coverage on 8aa6266 wanted to post the following:

Framework coverage

	b3924e	#28872 8aa626
	Total	Total	+/-	New
Rate	85.05%	85.05%	+0.00%	94.74%
Hits	106298	106335	+37	36
Misses	18691	18692	+1	2

Diff coverage report

Full coverage report

Modules coverage

Optimization

	b3924e	#28872 8aa626
	Total	Total	+/-	New
Rate	88.55%	88.65%	+0.10%	96.43%
Hits	1972	1999	+27	27
Misses	255	256	+1	1

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild · 2024-10-22T00:00:44Z

Job Precheck, step Clang format on b1fad52 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28872/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format b3924ece4ed556a7ca9811a6e046eb5c4503df72

lynnmunday

Lots of ternaries, very clever!

lynnmunday · 2024-10-22T20:34:57Z

framework/doc/content/source/materials/ReporterOffsetFunctionMaterial.md

+
+!syntax description /Materials/ReporterOffsetFunctionMaterial
+
+This can be used to create a material that is the sum of a function that is shifted by a set of points. This can be useful for creating a field of laser heat sources.


Suggested change

This can be used to create a material that is the sum of a function that is shifted by a set of points. This can be useful for creating a field of laser heat sources.

This can be used to create a material that is the sum of a function that is shifted by a set of points. This can be useful for creating a field containing multiple sources, see Figure??.

lynnmunday · 2024-10-22T20:43:48Z

framework/include/materials/ReporterOffsetFunctionMaterial.h

+
+ /// x coordinate
+ const std::vector<Real> & _coordx;
+ /// y coordinate
+ const std::vector<Real> & _coordy;
+ ///z coordinate
+ const std::vector<Real> & _coordz;
+ ///xyz point
+ const std::vector<Point> & _points;


Suggested change

/// x coordinate

const std::vector<Real> & _coordx;

/// y coordinate

const std::vector<Real> & _coordy;

///z coordinate

const std::vector<Real> & _coordz;

///xyz point

const std::vector<Point> & _points;

/**

* Reporter offset locations for function

*/

// @{

/// x coordinate

const std::vector<Real> & _coordx;

/// y coordinate

const std::vector<Real> & _coordy;

///z coordinate

const std::vector<Real> & _coordz;

///xyz point

const std::vector<Point> & _points;

// @}

lynnmunday · 2024-10-22T20:44:55Z

framework/include/materials/ReporterOffsetFunctionMaterial.h

+ /// The function being used for evaluation
+ const Function & _func;
+ /**
+ * Calculates the value of the offset function at the given point.


Suggested change

* Calculates the value of the offset function at the given point.

* Calculates the value of the function at the given offset point.

lynnmunday · 2024-10-22T20:46:48Z

framework/include/materials/ReporterOffsetFunctionMaterial.h

+
+private:
+ /// convenience vectors (these are not const because reporters can change their size)
+ std::vector<Real> _ones_vec;


you don't need this one.

lynnmunday · 2024-10-22T20:48:33Z

modules/optimization/include/materials/MisfitReporterOffsetFunctionMaterial.h

+
+private:
+ /// convenience vectors (these are not const because reporters can change their size)
+ std::vector<Real> _ones_vec;
+ std::vector<Real> _zeros_vec;
+ std::vector<Point> _zeros_pts;


Suggested change

private:

/// convenience vectors (these are not const because reporters can change their size)

std::vector<Real> _ones_vec;

std::vector<Real> _zeros_vec;

std::vector<Point> _zeros_pts;

lynnmunday · 2024-10-22T20:50:42Z

modules/optimization/src/materials/MisfitReporterOffsetFunctionMaterial.C

+ "Computes the misfit and misfit gradient materials for inverse optimizations problems.");
+
+ params.addRequiredCoupledVar("sim_variable",
+ "Variable that is being for the simulation variable.");


Suggested change

"Variable that is being for the simulation variable.");

"Variable that is being used for the simulation variable.");

lynnmunday · 2024-10-22T21:19:32Z

modules/optimization/test/tests/optimizationreporter/function_misfit/forward_and_adjoint_side.i

+ type = SideIntegralMaterialProperty
+ boundary = top
+ property = obj_misfit
+ execute_on = 'ADJOINT_TIMESTEP_END TIMESTEP_END'


Do you need ADJOINT_TIMESTEP_END

lynnmunday · 2024-10-22T21:21:50Z

modules/optimization/test/tests/optimizationreporter/function_misfit/main_auto.i

+ ## THESE OPTIONS ARE FOR TESTING THE ADJOINT GRADIENT
+ # petsc_options_iname = '-tao_max_it -tao_fd_test -tao_test_gradient -tao_fd_gradient -tao_fd_delta -tao_gatol'
+ # petsc_options_value = '1 true true false 1e-3 1e-5'
+ # petsc_options = '-tao_test_gradient_view'


Suggested change

## THESE OPTIONS ARE FOR TESTING THE ADJOINT GRADIENT

# petsc_options_iname = '-tao_max_it -tao_fd_test -tao_test_gradient -tao_fd_gradient -tao_fd_delta -tao_gatol'

# petsc_options_value = '1 true true false 1e-3 1e-5'

# petsc_options = '-tao_test_gradient_view'

We shouldn't put these in these commented out tao options for the fd gradient in new input files. I do find them helpful.

lynnmunday · 2024-10-22T21:24:31Z

modules/optimization/test/tests/optimizationreporter/function_misfit/tests

+ abs_zero = 1e-4
+ # steady solve
+ recover = false
+ detail = 'for side only measurements.'


Suggested change

detail = 'for side only measurements.'

detail = 'for side only measurements and fewer measurements than controllable parameters.'

trying to point out this problem is under constrained.

lynnmunday · 2024-10-22T21:26:41Z

modules/optimization/test/tests/optimizationreporter/function_misfit/main_auto_side.i

+ num_values = '3'
+[]
+
+[Reporters]


I like this reporter on the sub-app so that you don't have to transfer it.

lynnmunday · 2024-10-22T21:32:49Z

modules/optimization/doc/content/source/materials/MisfitReporterOffsetFunctionMaterial.md

+- Measurement values $\mathbf{u}_m = \{u_{m,1}, u_{m,2}, \ldots, u_{m,n}\}$
+- Measurement Locations: $\mathbf{p}_m = \{\mathbf{p}_{m,1}, \mathbf{p}_{m,2}, \ldots, \mathbf{p}_{m,n}\}$, where $\mathbf{p}_{m,i} = (x_{m,i}, y_{m,i}, z_{m,i})$ for 3D data
+
+- Simulation variable: $u(\mathbf{x})$
+- Gaussian beam width: $w$
+- Simulation point: $\mathbf{x}$
+
+The `misfit` at a given simulation point $\mathbf{x}$ is calculated as:
+
+$m(\mathbf{x}) = \sum_{i=1}^{n} \left( u_{m,i} g(\mathbf{p}_{m,i}, \mathbf{x}) - u(\mathbf{x}) g(\mathbf{p}_{m,i}, \mathbf{x}) \right)^2,$
+
+where:
+
+- $g(\mathbf{p}_{m,i}, \mathbf{x})$ is the Gaussian weighting function, defined as:
+
+$g(\mathbf{p}_{m,i}, \mathbf{x}) = \exp\left( -\frac{2 \|\mathbf{p}_{m,i} - \mathbf{x}\|^2}{w^2} \right),$
+
+and the `misfit gradient` with respect to the simulation variable $u(\mathbf{x})$ is:
+
+$\frac{\partial m(\mathbf{x})}{\partial u(\mathbf{x})} = -2 \sum_{i=1}^{n} g(\mathbf{p}_{m,i}, \mathbf{x}) \left( u_{m,i} g(\mathbf{p}_{m,i}, \mathbf{x}) - u(\mathbf{x}) g(\mathbf{p}_{m,i}, \mathbf{x}) \right).$


THis needs to be corrected for a general function and not just a gaussian. You can keep the gaussian as an example but its not really relevant anymore. Maybe reference the input file function:
!listing test/tests/optimizationreporter/function_misfit/forward_and_adjoint.i block=Functions

lynnmunday · 2024-10-22T21:43:35Z

modules/optimization/include/materials/MisfitReporterOffsetFunctionMaterial.h

+ /// Simulation variable
+ const GenericVariableValue<is_ad> & _sim_var;
+
+ /// Gradient of misfit with respect to material properties


wrt simulation variable

maxnezdyur added 5 commits October 15, 2024 15:36

start of guass prob misfit

d2bc44e

update gradient

56e001b

Add guassian misfit (idaholab#28871)

1330876

update guassianmisfit markdown file

518b4dd

update test

aa57786

maxnezdyur requested review from zachmprince and dschwen as code owners October 17, 2024 14:38

fix outputs in input file

fc71c9c

maxnezdyur force-pushed the line_obj branch 2 times, most recently from 6628c4d to c5bc150 Compare October 17, 2024 19:19

abs_zero has to be higher than gatol

48dfd6f

maxnezdyur force-pushed the line_obj branch from c5bc150 to 48dfd6f Compare October 21, 2024 11:39

maxnezdyur added 2 commits October 21, 2024 17:31

add ability to have different weighitng functions

448bc7a

rename to more general name

81f8bed

maxnezdyur requested a review from lindsayad as a code owner October 21, 2024 23:55

maxnezdyur marked this pull request as draft October 21, 2024 23:55

fix name changes

1fb3b66

maxnezdyur force-pushed the line_obj branch 4 times, most recently from f01337f to f07deef Compare October 22, 2024 12:21

add explicit init

58841d0

maxnezdyur force-pushed the line_obj branch from f07deef to 58841d0 Compare October 22, 2024 12:23

maxnezdyur added 2 commits October 22, 2024 06:45

template material

30fa858

update docs

8aa6266

lynnmunday suggested changes Oct 22, 2024

View reviewed changes

lynnmunday reviewed Oct 22, 2024

View reviewed changes

moosebuild added the PR: Failed but allowed label Oct 22, 2024

lynnmunday reviewed Oct 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gaussian Probe optimization #28872

Gaussian Probe optimization #28872

maxnezdyur commented Oct 17, 2024

moosebuild commented Oct 17, 2024 •

edited

Loading

moosebuild commented Oct 17, 2024 •

edited

Loading

moosebuild commented Oct 22, 2024

lynnmunday left a comment

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024

lynnmunday Oct 22, 2024


		!syntax description /Materials/ReporterOffsetFunctionMaterial

		This can be used to create a material that is the sum of a function that is shifted by a set of points. This can be useful for creating a field of laser heat sources.

	* Calculates the value of the offset function at the given point.
	* Calculates the value of the function at the given offset point.

	"Variable that is being for the simulation variable.");
	"Variable that is being used for the simulation variable.");

	detail = 'for side only measurements.'
	detail = 'for side only measurements and fewer measurements than controllable parameters.'

Gaussian Probe optimization #28872

Are you sure you want to change the base?

Gaussian Probe optimization #28872

Conversation

maxnezdyur commented Oct 17, 2024

moosebuild commented Oct 17, 2024 • edited Loading

moosebuild commented Oct 17, 2024 • edited Loading

Framework coverage

Modules coverage

Optimization

Full coverage reports

moosebuild commented Oct 22, 2024

lynnmunday left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Oct 17, 2024 •

edited

Loading

moosebuild commented Oct 17, 2024 •

edited

Loading