Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single configure option for reference representation #361

Open
sharon-wang opened this issue Nov 12, 2020 · 2 comments
Open

Create single configure option for reference representation #361

sharon-wang opened this issue Nov 12, 2020 · 2 comments

Comments

@sharon-wang
Copy link
Contributor

sharon-wang commented Nov 12, 2020

To avoid having to consider the precedence of --with-mixedrefs (introduced in #359) and --with-noncompressedrefs, we should introduce a new configure option --with-references=[full|compressed|mixed-static|mixed-dynamic] to cover all reference representation modes.

Proposed by @keithc-ca (#359 (review)).

These changes will need to go in each of the extensions repos.

More mixed builds discussion: eclipse-openj9/openj9#8878

@keithc-ca
Copy link
Member

I'm not thrilled with the names of the choices, but the list is a start and we appear to have agreement on the meanings of the choices.

Note, this will have implications for adoptopenjdk.net (i.e. 'xl' builds using --with-noncompressedrefs).

@sharon-wang
Copy link
Contributor Author

When we address #361 we should add more checking (e.g. mixedrefs should not be accepted for (supported) 32-bit targets).

From ibmruntimes/openj9-openjdk-jdk8#459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants