-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use Inventory Item "PrettyName" for Redfish Name #3158
Labels
Milestone
Comments
gtmills
changed the title
Should use Inventory Item "PrettyName"
Should use Inventory Item "PrettyName" for Redfish Name
May 7, 2021
Google has a review here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/43967 |
Downstream PR here: ibm-openbmc/bmcweb#93 |
aahmed-2
added
Downstream
Used for stories that will only be implemented downstream
In Review
and removed
In Review
labels
Sep 14, 2021
Code review in driver |
refresh again |
Closing. Work is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
openbmc/bmcweb#204
We should look for PrettyName and if it isn't there fall back to the last segment of the URI
https://ibm-systems-power.slack.com/archives/C1HT3FHNK/p1620407582169500?thread_ts=1620123529.115600&cid=C1HT3FHNK
https://github.com/openbmc/phosphor-dbus-interfaces/blob/495981805244269650bee13d1ee8f13543b2bc5a/xyz/openbmc_project/Inventory/Item.interface.yaml#L5
See review: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40158
This should be a series of commits
The text was updated successfully, but these errors were encountered: