Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming convention for ephemeris files #219

Open
FredSchuller opened this issue Jul 10, 2024 · 2 comments · May be fixed by #221
Open

Update naming convention for ephemeris files #219

FredSchuller opened this issue Jul 10, 2024 · 2 comments · May be fixed by #221
Assignees
@FredSchuller
Labels
enhancement New feature or request reviewed 2024-10
Milestone
Version 0.6.0

Comments

@FredSchuller
Copy link
Collaborator

After discussion with ESA, the agreement was that the ancillary files with ephemeris and pointing info shoul be named:
solo_ANC_stix-aux-ephemeris_..._V...fits

To do: update pieces of code here and there to make them compatible with the new names.
@FredSchuller
Copy link
Collaborator Author

FredSchuller commented Jul 10, 2024 •
edited
Loading

To be decided: should the code be backward compatible (i.e. able to read both "aux" files with previous naming and new naming)?

@nicHoch
Copy link
Contributor

nicHoch commented Jul 10, 2024 •
edited
Loading

@FredSchuller please note the new name:

i4Ds/STIXCore#396

and as we still do not have approval from ESA please wait until i ping you in that issue.

To your main question: for a easy transition it would be very nice if it is backward compatible. But this totally depends on you how much effort this is and if the code still stays maintainable for longer time.

if it is not backward compatible we have to plan the release more carefully

@samaloney samaloney added the enhancement New feature or request label Oct 15, 2024
@samaloney samaloney linked a pull request Oct 15, 2024 that will close this issue
Rename aux files #221
Open
@ennosigaeus ennosigaeus added this to the Version 0.6.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FredSchuller FredSchuller

Labels
enhancement New feature or request reviewed 2024-10
Projects
None yet
Milestone
Version 0.6.0
Development

Successfully merging a pull request may close this issue.

Rename aux files FredSchuller/STIX-GSW
4 participants
@ennosigaeus @nicHoch @samaloney @FredSchuller