Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask-related test failures in pull request #571

Open
mpluess opened this issue May 23, 2024 · 1 comment
Open

Dask-related test failures in pull request #571

mpluess opened this issue May 23, 2024 · 1 comment
Labels
bug Something isn't working prio-med Medium priority

Comments

@mpluess
Copy link
Member

mpluess commented May 23, 2024

After creating a pull request unrelated to Dask, two tests involving Dask failed. See this log for details: https://github.com/i4Ds/Karabo-Pipeline/actions/runs/9172253662/job/25218346513?pr=569

To avoid the test failures, I disabled Dask in the two affected tests, see comments with "TODO DASK_TEST_ISSUE" prefix in the code base.

This should be looked at in detail though to make sure Dask is working as expected.

@mpluess mpluess added bug Something isn't working prio-med Medium priority labels May 23, 2024
@mpluess
Copy link
Member Author

mpluess commented May 27, 2024

Something seems to be off indeed with Dask.
In source_detection.ipynb, running the following code twice:
restored = RascilImageCleaner( RascilImageCleanerConfig( imaging_npixel=imaging_npixel, imaging_cellsize=imaging_cellsize, ingest_vis_nchan=16, clean_nmajor=1, clean_algorithm="mmclean", clean_scales=[10, 30, 60], clean_threshold=0.12e-3, clean_nmoment=5, clean_psf_support=640, clean_restored_output="integrated", use_dask=True, ) ).create_cleaned_image( ms_file_path=visibility_askap.ms_file_path, )
results in a "RuntimeError: IOLoop is closed" as well (first run is fine, second one crashes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio-med Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant