Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline PackageReference PrivateAssets attribute is removed #268

Open
starkcolin opened this issue Oct 7, 2019 · 0 comments
Open

Inline PackageReference PrivateAssets attribute is removed #268

starkcolin opened this issue Oct 7, 2019 · 0 comments

Comments

@starkcolin
Copy link

starkcolin commented Oct 7, 2019 •
edited
Loading

When upgrading or cleaning up csproj files that have inline PrivateAssets attributes on PackageReference items, the attributes are incorrectly removed.

Example:
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.6" PrivateAssets="All" />

becomes:
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.6" />

I am not sure if this occurs with any other inline attributes, but all attributes should be preserved on upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starkcolin