Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can it migrate PreBuildEvent and PostBuildEvent too #267

Open
kirchsth opened this issue Sep 25, 2019 · 0 comments
Open

Can it migrate PreBuildEvent and PostBuildEvent too #267

kirchsth opened this issue Sep 25, 2019 · 0 comments

Comments

@kirchsth
Copy link

Thank you for the tool, it makes a great job.

Could you migrate the PreBuildEvent and PostBuildEvent too? Because without changes no macros like e.g. $(ProjectDir) are replaced anymore. But if you would convert them into tasks then they are replaced again.

e.g.
Old:

<PropertyGroup>
     <PreBuildEvent>"$(ProjectDir)PreBuildEvent.bat" "$(ProjectDir)..\" "$(ProjectDir)" "$(TargetDir)" 0 />
</PropertyGroup>

New:

<Target Name="PreBuild" BeforeTargets="PreBuildEvent">
   <Exec Command="&quot;$(ProjectDir)PreBuildEvent.bat&quot; &quot;$(ProjectDir)..\&quot; &quot;$(ProjectDir)&quot; &quot;$(TargetDir)&quot; &quot;$(DevEnvDir)&quot; 0" />
</Target>

Details can be found dotnet/project-system#1569

Thank you and best regards
Helmut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant