Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support #31

Open
suphamster opened this issue Apr 19, 2023 · 2 comments
Open

Unicode support #31

suphamster opened this issue Apr 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@suphamster
Copy link

It seems that for now unicode file names is not supported since after unpacking .pck I got few files that can't be packed back properly, For example: original file name "魔王魂 アコースティック25.ogg-0683c3a09e15adb36630a670de69ac05.oggstr" (got it with Godot RE Tools), GodotPckTool generated file name "魔王魂 アコースティック25.ogg-0683c3a09e15adb36630a670de69ac05.oggstr" so at importing back I got such error:

terminate called after throwing an instance of 'std::filesystem::__cxx11::filesystem_error'
  what():  filesystem error: cannot get file size: No such file or directory [extracted\.import\├Р┬У├В┬й├Р┬Т├В┬н├Р┬Т├в┬А┬Э├Р┬У├В┬з├Р┬Т├Р┬Л├Р┬Т├в┬А┬╣├Р┬У├В┬й├Р┬Т├В┬н├Р┬Т├в┬А┬Ъ ├Р┬У├Р┬И├Р┬Т├в┬А┬Ъ├Р┬Т├С┬Ю├Р┬У├Р┬И├Р┬Т├в┬А┬Ъ├Р┬Т├С┬Ц├Р┬У├Р┬И├Р┬Т├С┬У├Р┬Т├С┬Ш├Р┬У├Р┬И├Р┬Т├в┬А┬Ъ├Р┬Т├в┬Д┬Ц├Р┬У├Р┬И├Р┬Т├С┬У├Р┬Т├в┬А┬а├Р┬У├Р┬И├Р┬Т├в┬А┬Ъ├Р┬Т├Р┬И├Р┬У├Р┬И├Р┬Т├С┬У├Р┬Т├С┬У├Р┬У├Р┬И├Р┬Т├в┬А┬Ъ├Р┬Т├Р┬З06.ogg-bcfff188be40b560c38e232ce419ff3c.oggstr]
@hhyyrylainen hhyyrylainen added the enhancement New feature or request label Apr 19, 2023
@hhyyrylainen
Copy link
Owner

I hadn't tested with those kinds of paths, so it isn't exactly surprising that they don't work entirely correctly. Is that on Windows? Because I would guess that on Linux it should actually all just work correctly using utf-8, but on Windows utf-16 encoded text is likely problematic.

@suphamster
Copy link
Author

Yes, on Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants