Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded pck files #26

Open
KANAjetzt opened this issue Jan 27, 2023 · 6 comments
Open

Embedded pck files #26

KANAjetzt opened this issue Jan 27, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@KANAjetzt
Copy link

Hi, first of all thanks for this great tool!

Is it possible to access the pck file if it is embedded in to the .exe?

I'm co creating a mod loader and as ithinkandicode mentioned in #25 we are using it with great success to add the mod loader autoload at the right spot to the project.binary.

Now we have the issue that some games embed the pck and it looks like we cant access that with the PckTool.

@ithinkandicode
Copy link

I second that this tool is great 🤗

For reference, extracting the PCK from the EXE is possible with GodotPCKExplorer. We'd like to limit our dependencies if possible, and if you think this would be a helpful/viable feature to add to PckTool.

@hhyyrylainen
Copy link
Owner

This sounds like a pretty doable feature. One tricky part is that I assume the executable layouts are different enough that separate code for finding the start of the embedded pck will be needed for Linux, Windows and mac.

@KANAjetzt
Copy link
Author

Great news!

Can you give us an estimate on how long this might take to implement?
Totally understandable if you don't have the time right now.
I might be able to find someone to create a PR for this issue.

@hhyyrylainen
Copy link
Owner

Well, so far I've only implemented features I need myself for this tool so... I don't really plan on working on this feature myself but I'll accept a pull request adding this feature.
The game I need to use this tool on, Thrive, is one I'm part of developing so there's no foreseeable need to have embedded pck support for my use case.

@KANAjetzt
Copy link
Author

Makes a lot of sense. Thanks for the quick response 👍

@nikitalita
Copy link
Contributor

You can steal the implementation that I have here for this: https://github.com/bruvzg/gdsdecomp/blob/master/utility/gdre_packed_source.cpp#L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants