Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could there be a problem with the initialization of GaussianPolicy ? #19

Open
guyk1971 opened this issue Oct 18, 2018 · 0 comments
Open

Comments

@guyk1971
Copy link

GaussianPolicy inherits from NNPolicy and in the end of GaussianPolicy constructor (init) there is a call to the parent of NNPolicy...
shouldnt it be :
super(GaussianPolicy,self).__init__(env_spec)

I observed its repeating in latent_space_policy and gmm_policy as well (although there is a comment in gmm_policy about it).

so not sure its a mistake, probably my misunderstanding, but sending anyway.
Thanks for sharing the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant