Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on code.google.com/p/goprotobuf/proto #73

Open
33N opened this issue May 10, 2015 · 2 comments
Open

dependency on code.google.com/p/goprotobuf/proto #73

33N opened this issue May 10, 2015 · 2 comments

Comments

@33N
Copy link

33N commented May 10, 2015

I pulled down code... running ./all.sh I get:
package github.com/ha/doozer
imports code.google.com/p/goprotobuf/proto: unable to detect version control system for code.google.com/ path

I made changes in the files, replace the code.google.com with proper git hub imports in:
modified: .travis.yml
modified: consensus/m.pb.go
modified: consensus/m_test.go
modified: consensus/manager.go
modified: consensus/manager_test.go
modified: consensus/run.go
modified: consensus/run_test.go
modified: doc/hacking.md
modified: doc/proto.md
modified: server/conn.go
modified: server/msg.pb.go
modified: server/server_test.go
modified: server/txn.go
modified: web/web.go

I can't find any more references, but somewhere I the code is still looking for code.google.com, preventing build.

@33N
Copy link
Author

33N commented May 10, 2015

I found the problem references in the ha/doozer package (which I confused with ha/doozerd at first).
Generally all fixed similar to this issue: google/codesearch#42
Because of the dependency on the client: ha/doozer will need to be updated to make the server: ha/doozerd work.

Still working out issues moving to the websocket package.

@33N
Copy link
Author

33N commented May 14, 2015

Fixed and submitted pull request.
Imported golang.org/x/net/websocket successfully.
I also submitted a pull request on ha/doozer: this package (ha/doozerd) has a dependency on ha/doozer (its client package) which also requires the protobuf imports to be updated to use github.

Until the ha/doozer pull request is accepted, doozerd will not successfully build using travis.
Doozerd runs and tests fine locally, with the dozer change applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant