Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Make JitsiMeet methods non-static #234

Open
1 of 3 tasks
tuantvu opened this issue Apr 4, 2021 · 0 comments
Open
1 of 3 tasks

[FEATURE]: Make JitsiMeet methods non-static #234

tuantvu opened this issue Apr 4, 2021 · 0 comments
Labels
backlog Added to the backlog enhancement New feature or request

Comments

@tuantvu
Copy link
Collaborator

tuantvu commented Apr 4, 2021

Description

Static methods are not conducive to mocking in unit test. Also, the idea of global listeners vs per meeting listeners bloat the code and make it complex.

Is the feature supported by Jitsi?
jitsi_meet Flutter plugin is dependent on the Android and iOS SDK from jitsi.org. If those SDKs do not support a feature, we also can not add it.

  • Yes: Paste link to Jitsi documentation here
  • No
  • N/A

Describe the solution you'd like

Enable clients to instantiate JitsiMeet like final jitsiMeet = JitsiMeet(). Test if more than one JitsiMeet conference can even be opened at the same time. If not, maybe implement a singleton like JitsiMeet.instance.

Describe alternatives you've considered

Additional context

@tuantvu tuantvu added the enhancement New feature or request label Apr 4, 2021
@tuantvu tuantvu added this to the 3.3.0 Feature Flags and Events milestone Apr 4, 2021
@tuantvu tuantvu added the backlog Added to the backlog label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Added to the backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant