Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pending-ops not really working #4

Open
zerg000000 opened this issue Nov 7, 2022 · 1 comment
Open

pending-ops not really working #4

zerg000000 opened this issue Nov 7, 2022 · 1 comment

Comments

@zerg000000
Copy link

zerg000000 commented Nov 7, 2022 •
edited
Loading

awyeah-api/src/com/grzm/awyeah/http_client.clj

Line 170 in 1810bf6

(swap! pending-ops dec))

The pending-ops should be dec when submit request is complete, but now it is called right after submit is fired, which means pending-ops will never reach limit.

consider dec in onComplete.
@grzm
Copy link
Owner

grzm commented Nov 7, 2022

Thanks for the report! I'll look into it.

@grzm grzm mentioned this issue Nov 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grzm @zerg000000