Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping Notes in React App with MidiPlayer #97

Open
15077693d opened this issue Apr 6, 2023 · 1 comment
Open

Overlapping Notes in React App with MidiPlayer #97

15077693d opened this issue Apr 6, 2023 · 1 comment

Comments

@15077693d
Copy link

15077693d commented Apr 6, 2023 •
edited
Loading

Thank you for creating this project. I've noticed a potential issue while using the React app with MidiPlayer. When I click play, the notes seem to overlap. I wanted to bring this to your attention and provide an example in this sandbox: https://codesandbox.io/s/sax-practice-u4zl99?file=/src/App.tsx.
@15077693d 15077693d changed the title note overlay note overlap Apr 6, 2023
@15077693d 15077693d changed the title note overlap Overlapping Notes in React App with MidiPlayer Apr 6, 2023
@Andrew-J-Larson
Copy link

Andrew-J-Larson commented Jun 7, 2023 •
edited
Loading

Not a bug, but sounds like it could be a useful (togglable) feature to prematurely end a note when a new one starts on wind/brass instruments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andrew-J-Larson @15077693d