Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitEvent() should emit multiple events with the same tick #87

Open
serg472 opened this issue Jul 14, 2022 · 0 comments
Open

emitEvent() should emit multiple events with the same tick #87

serg472 opened this issue Jul 14, 2022 · 0 comments
Labels

Comments

@serg472
Copy link

serg472 commented Jul 14, 2022

Currently play() method is returning a single emitEvent() every 5ms even if there was a series of events on the same tick. It should return all events from the same tick in an array.
For example if your midi starts with the standard sequence "time signature", "key signature" etc all these are returned with 5ms intervals between them. Imagine if your midi starts with a hundred of silent system events this would delay the playback for seconds. Not only that, but It's adding 5ms delays where they are not expected to be, which causes all sorts of weird timing issues (silent events are decreasing the durations of following note-on events; note-off and note-on are 5ms apart where they should be smoothly following each other, etc).

Thanks.

@grimmdude grimmdude added the bug label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants