We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
The bind function is not watching deep with key like some.inner because angular.isObject always returns false with call: isObject(scope[key])
some.inner
isObject(scope[key])
The correct is object test must be: isObject($parse(key)(scope))
isObject($parse(key)(scope))
Possible related issues: #322
Best regards, Bernardo Baumblatt.
The text was updated successfully, but these errors were encountered:
Anyone who uses this feature have any thoughts?
Sorry, something went wrong.
Hello Gregory,
Are you asking for a solution or an opinion? Well, I think that is the first option because of bug label.
In this case, my fault, I was not clear enough. Let me try again..
Actual Code:
var bindToScope = function(scope, key, def, lsKey, type) { ........ return scope.$watch(key, function(newVal) { addToLocalStorage(lsKey, newVal, type); }, isObject(scope[key]));
Fixed Code:
var bindToScope = function(scope, key, def, lsKey, type) { ........ return scope.$watch(key, function(newVal) { addToLocalStorage(lsKey, newVal, type); }, isObject($parse(key)(scope)));
So, and the fix goes to ... line 466!
Best regards, Bernardo Baumblatt
No branches or pull requests
Hello,
The bind function is not watching deep with key like
some.inner
because angular.isObject always returns false with call:isObject(scope[key])
The correct is object test must be:
isObject($parse(key)(scope))
Possible related issues:
#322
Best regards,
Bernardo Baumblatt.
The text was updated successfully, but these errors were encountered: