Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helpers from contracts to common-ts #37

Open
davekaj opened this issue Jul 31, 2020 · 1 comment
Open

Move helpers from contracts to common-ts #37

davekaj opened this issue Jul 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@davekaj
Copy link

davekaj commented Jul 31, 2020

The function here:

https://github.com/graphprotocol/contracts/blob/master/scripts/contracts/connectedContracts.ts

Can be moved here. I think the simple function like staking are probably duplicated and can be removed. But this is what I think is valuable:

  • EthereumDID registry functions - this will help nena in the front end with Account Metadata, Subgraph Metadata, and Version metadata handling
  • creating new subgraphs and new subgraph versions - This will also help in the front end

All other functions are probably duplicate. If not , they are simple and we can add them

@davekaj
Copy link
Author

davekaj commented Jul 31, 2020

@nenadjaja @Jannis

@Jannis Jannis changed the title I have some function in graphprotocol/contracts that should get moved here Move helpers from contracts to common-ts Dec 21, 2020
@Jannis Jannis added chore enhancement New feature or request and removed chore labels Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants