From 2da414b85c2159b4240b0743a9ce0e9b27777093 Mon Sep 17 00:00:00 2001 From: Shirley Leu <4163034+fridgepoet@users.noreply.github.com> Date: Thu, 26 Sep 2024 14:44:06 +0200 Subject: [PATCH] Lint complaints --- ...data_source_metrics_endpoint_scrape_job_test.go | 14 +++++++------- .../resource_metrics_endpoint_scrape_job_test.go | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/internal/resources/connections/data_source_metrics_endpoint_scrape_job_test.go b/internal/resources/connections/data_source_metrics_endpoint_scrape_job_test.go index 078cb3d68..c15bb5719 100644 --- a/internal/resources/connections/data_source_metrics_endpoint_scrape_job_test.go +++ b/internal/resources/connections/data_source_metrics_endpoint_scrape_job_test.go @@ -13,9 +13,9 @@ func TestAcc_DataSourceMetricsEndpointScrapeJob(t *testing.T) { // Expected result: test fails and the error message should be "failed to create metrics endpoint scrape job: failed to do request" // because the Connections API is not yet available. - t.Skip("will be enabled after Connections API is available in prod") + // t.Skip("will be enabled after Connections API is available in prod") - //testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available + // testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available resource.ParallelTest(t, resource.TestCase{ ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories, Steps: []resource.TestStep{ @@ -37,11 +37,11 @@ func TestAcc_DataSourceMetricsEndpointScrapeJob(t *testing.T) { { // Verifies that the created SLO Resource is read by the Datasource Read Method // TODO: work on after other Test Step passes - //Config: testutils.TestAccExample(t, "data-sources/grafana_connections_metrics_endpoint_scrape_job/resource.tf"), - //RefreshState: true, - //Check: resource.ComposeTestCheckFunc( - // resource.TestCheckResourceAttrSet("data.grafana_connections_metrics_endpoint_scrape_job.test", "test.0.name"), - //), + // Config: testutils.TestAccExample(t, "data-sources/grafana_connections_metrics_endpoint_scrape_job/resource.tf"), + // RefreshState: true, + // Check: resource.ComposeTestCheckFunc( + // resource.TestCheckResourceAttrSet("data.grafana_connections_metrics_endpoint_scrape_job.test", "test.0.name"), + // ), }, }, }) diff --git a/internal/resources/connections/resource_metrics_endpoint_scrape_job_test.go b/internal/resources/connections/resource_metrics_endpoint_scrape_job_test.go index b0812056a..f4791e561 100644 --- a/internal/resources/connections/resource_metrics_endpoint_scrape_job_test.go +++ b/internal/resources/connections/resource_metrics_endpoint_scrape_job_test.go @@ -25,9 +25,9 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) { // Expected result: test fails and the error message should be "failed to create metrics endpoint scrape job: failed to do request" // because the Connections API is not yet available. - //t.Skip("will be enabled after Connections API is available in prod") + // t.Skip("will be enabled after Connections API is available in prod") - //testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available + // testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available resource.ParallelTest(t, resource.TestCase{ ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories, CheckDestroy: testAccMetricsEndpointCheckDestroy("test-stack-id", "my-scrape-job"), @@ -48,7 +48,7 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) { ), }, // TODO: work on this after "Test Create" and "CheckDestroy" pass - //{ + // { // // Tests Update // Config: testutils.TestAccExample(t, "resources/grafana_connections_metrics_endpoint_scrape_job/resource_update.tf"), // Check: resource.ComposeTestCheckFunc( @@ -60,7 +60,7 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) { // resource.TestCheckResourceAttr("grafana_connections_metrics_endpoint_scrape_job.test", "url", "https://www.modified-url.com:9000/metrics"), // resource.TestCheckResourceAttr("grafana_connections_metrics_endpoint_scrape_job.test", "scrape_interval_seconds", "120"), // ), - //}, + // }, }, }) }