CG.Web.MegaApiClient.MegaApiClient.Login > Unable to cast object of type 'System.Int64' to type 'Newtonsoft.Json.Linq.JArray'

[dhabierre]

Description:

The error occurres while executing the MegaApiClient LoginAsync method (~1 year without any error):

private readonly MegaApiClient client = new();

[...]

private async Task<MegaApiClient> GetClientAsync()
{
    if (!this.client.IsLoggedIn)
    {
        var options = this.options.Mega;

        await this.client.LoginAsync(options.Username, options.Password);
    }

    return this.client;
}

Locally on my dev computer, no issue, everything is OK.

But once the app is deployed on my VM provider:

System.InvalidCastException: Unable to cast object of type 'System.Int64' to type 'Newtonsoft.Json.Linq.JArray'
   at CG.Web.MegaApiClient.MegaApiClient.RequestCore[TResponse](RequestBase request, Byte[] key)\n  
   at CG.Web.MegaApiClient.MegaApiClient.Request[TResponse](RequestBase request, Byte[] key)\n  
   at CG.Web.MegaApiClient.MegaApiClient.GenerateAuthInfos(String email, String password, String mfaKey)\n   
   at CG.Web.MegaApiClient.MegaApiClient.Login(String email, String password, String mfaKey)\n   
   at CG.Web.MegaApiClient.MegaApiClient.<>c__DisplayClass62_0.<LoginAsync>b__0()\n   
   at System.Threading.Tasks.Task`1.InnerInvoke()\n   
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\n--- End of stack trace from previous location ---\n   
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\n--- End of stack trace from previous location ---\n   
   at ****.Infrastructure.CloudStorage.MegaCloudStorageService.GetClientAsync() in D:\\a\\1\\s\\src\\Backend\\3-Infrastructure\\****.Infrastructure.CloudStorage\\MegaCloudStorageService.cs:line 152\n   
   ...

MegaApiClient Version: 1.10.3

Thanks.

[dhabierre]

Something like this fix the return (report to comments):

private TResponse RequestCore<TResponse>(RequestBase request, byte[] key)
    where TResponse : class
{
  var dataRequest = JsonConvert.SerializeObject(new object[] { request });
  var uri = GenerateUrl(request.QueryArguments);
  object jsonData = null;
  var attempt = 0;
  // Added line
  var apiCode = ApiResultCode.Ok;
  while (_options.ComputeApiRequestRetryWaitDelay(++attempt, out var retryDelay))
  {
    var dataResult = _webClient.PostRequestJson(uri, dataRequest);

    if (string.IsNullOrEmpty(dataResult)
      || (jsonData = JsonConvert.DeserializeObject(dataResult)) == null
      || jsonData is long
      || jsonData is JArray array && array[0].Type == JTokenType.Integer)
    {
      // Remove var keyword
      apiCode = jsonData == null
        ? ApiResultCode.RequestFailedRetry
        : jsonData is long
          ? (ApiResultCode)Enum.ToObject(typeof(ApiResultCode), jsonData)
          : (ApiResultCode)((JArray)jsonData)[0].Value<int>();

      if (apiCode != ApiResultCode.Ok)
      {
        ApiRequestFailed?.Invoke(this, new ApiRequestFailedEventArgs(uri, attempt, retryDelay, apiCode, dataResult));
      }

      if (apiCode == ApiResultCode.RequestFailedRetry)
      {
        Wait(retryDelay);
        continue;
      }

      if (apiCode != ApiResultCode.Ok)
      {
        throw new ApiException(apiCode);
      }
    }

    break;
  }

  // Added block
  if (apiCode != ApiResultCode.Ok)
  {
    throw new ApiException(apiCode);
  }

  var data = ((JArray)jsonData)[0].ToString();
  return (typeof(TResponse) == typeof(string)) ? data as TResponse : JsonConvert.DeserializeObject<TResponse>(data, new GetNodesResponseConverter(key));
}

[gpailler]

@dhabierre Thanks for the issue report. Would you mind proposing a PR?
Thanks !

[dhabierre]

Hi @gpailler, I can do it at the end of the next week (in holidays at present time).