Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the example of setClientEndpoint adding how to change oauth endpoint #1971

Open
DKbyo opened this issue Apr 5, 2023 · 0 comments
Open
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@DKbyo
Copy link

DKbyo commented Apr 5, 2023

Currently the code here [1] is being used as a reference here [2] however in an on-prem environment using Private Service Connect is also necessary to change the oauth2 token endpoint in order to get the access token.

Is your feature request related to a problem? Please describe.
setClientEndpoint example is not complete if you would like to use this library on a PSC environment

Describe the solution you'd like
Improve the current setClientEndpoint example [1]

Describe alternatives you've considered
Add a new section on [2], it looks like every library might need this feature as well

[1] https://github.com/googleapis/java-storage/blob/main/samples/snippets/src/main/java/com/example/storage/bucket/SetClientEndpoint.java
[2] https://cloud.google.com/storage/docs/request-endpoints

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 5, 2023
@frankyn frankyn added type: docs Improvement to the documentation for an API. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants