Replies: 1 comment 1 reply
-
I don't remember seeing discussion about this internally. Some consideration was given to the initial set of heuristics, but I also don't think we've migrated a large amount of code using varifier so far, so I think there's certainly room to change the heuristics. To check my understanding, varifier has a heuristic to suggest rewriting I don't think |
Beta Was this translation helpful? Give feedback.
-
I assume this has been asked internally but I didn't see an external discussion. Perhaps I am naively or too opinionated, but it feels overly broad that primitive casts are included for
var
assignments. These are usually narrowing conversions such aswhere ticks is the current nano time and the mask is a fast modulus for indexing into a timing wheel.
There are of course cases where this suggestion makes it longer due to generics, but those seem more reasonable to not over optimize for, is consistent, and the LHS's type length shouldn't be a factor.
As such I may be over thinking it, it just feels a little awkward for primitive assignments and even worse to add suppressions lines for each of those.
Beta Was this translation helpful? Give feedback.
All reactions