Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Fedora and CentOS so vastly out of sync? Do they need to be synced more? #130

Open
obnoxxx opened this issue Feb 20, 2019 · 4 comments

Comments

@obnoxxx
Copy link

obnoxxx commented Feb 20, 2019

The centos and fedora containers are pretty much out of sync.

How the Dockerfile does things

Several things done differently in the container, like how to add files into the container, e.g.:

ADD gluster-setup.sh /usr/sbin/gluster-setup.sh

for centos and

COPY gluster-setup.sh [...] /
...
RUN ...&& \
...
mv /gluster-setup.sh /usr/sbin/gluster-setup.sh && \
...

for fedora, which seems less idiomatic and more complicated. So here a style / technique sync may be good.

Different components

Several mechanisms/components are only added to one of the containers, not both:

Fedora has

  • gluster-setup
  • fake-disk
  • gluster-brickmultiplex

Centos has:

  • gluster-setup
  • fake-disk
  • gluster-block-setup
  • update-params
  • status-probe
  • check-diskspace

Should we reconcile those services as much as possible?

What do people think?

@obnoxxx
Copy link
Author

obnoxxx commented Feb 20, 2019

@phlogistonjohn
Copy link

It's worthwhile but the last time I started doing it I got bogged down and never got far enough to make a PR. Maybe it would be best just to pick one (centos probably) and remove the other?

@jarrpa
Copy link

jarrpa commented Feb 21, 2019

+1 to John's suggestion. If we're not using it, no sense maintaining it.

@SaravanaStorageNetwork
Copy link
Member

same opinion here - it is better to maintain single container based on CentOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants