-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in updates from @dcomtois #1
Comments
Just a note... the site has moved to www.conjug.com |
@dcomtois Is your updated version of the database available online somewhere, or did it ever get merged into this repo? |
@dkirkby Sure, just check my fork: https://github.com/dcomtois/fred-jehle-spanish-verbs |
Referring to @dcomtois's update, is there a reason why "mudar(se)" appears rather than simply "mudar"? (there are separate entries for "mudarse"). |
No, this has been overlooked and should be corrected. Thx for pointing it out. Edit: Done. |
When the fork takes over the master... thanks @dcomtois ! |
@ghidinelli Want me to do a pull request, still? |
@dcomtois if you can do a PR against the repo, I'll merge it (and would appreciate it) |
I'll try to do a local merge before doing a PR, in case conflicts prevent it. Will let you know how this goes. Edit: Pls see my comment in the Pull requests section; the goodgravy:master merge should be rolled back prior to the merge, so that no conflicts arise. All the modifications from goodgravy are a subset of my own, so nothing will be lost. Also, I'm not sure that I need to create a new pull request... It seems that all commits are tracked down (at least this is what the Pull requests page suggests). Can you try to go ahead with the merge and see if my recent commits are included as well? |
I found a minor typo in cell I166 of @dcomtois's update:
Replace |
A few more typos in the english translations:
|
@dkirkby Fixed typos in Excel file, CSV and sqlite3 (in my branch). Thx for pointing them out. |
@dcomtois provided an updated version that needs to be merged in. He did his work in MySQL:
The text was updated successfully, but these errors were encountered: