Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach screenshots on events coming from the same frame #1827

Open
bruno-garcia opened this issue Oct 7, 2024 · 3 comments
Open

Don't attach screenshots on events coming from the same frame #1827

bruno-garcia opened this issue Oct 7, 2024 · 3 comments

Comments

@bruno-garcia
Copy link
Member

When Attach Screenshot is enabled, Sentry will attach a screenshot to all events. At firs this is the wanted behavior.
The problem comes from when an error happens on every frame. Resulting in lots of events with screenshots of basically the same game view.

Some ideas on how to improve this:
We should consider not attaching a screenshot if the UI didn't change from the previous error (e.g: same frame). Or perhaps if the timeframe between errors is to short.

Note:

@bitsandfoxes
Copy link
Contributor

Depends on #745

I imagine we could have the screenshots be added by some sort of processor that keeps track of when a screenshot was taken last and skip if it's too early.

@bitsandfoxes
Copy link
Contributor

Side note: If we slow it down enough we might have something like a session replay! Not really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants