-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't attach screenshots on events coming from the same frame #1827
Comments
Depends on #745 I imagine we could have the screenshots be added by some sort of processor that keeps track of when a screenshot was taken last and skip if it's too early. |
Here's an example when that happens: https://sentry.sentry.io/issues/5987813063/attachments/?attachmentFilter=screenshot&node=error-cfa4cebfdec847f4910ba5dde06201fd&project=5905698&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=0 Couple hundred events, all with screenshots, a lot quite similar/same: |
Side note: If we slow it down enough we might have something like a session replay! Not really. |
When Attach Screenshot is enabled, Sentry will attach a screenshot to all events. At firs this is the wanted behavior.
The problem comes from when an error happens on every frame. Resulting in lots of events with screenshots of basically the same game view.
Some ideas on how to improve this:
We should consider not attaching a screenshot if the UI didn't change from the previous error (e.g: same frame). Or perhaps if the timeframe between errors is to short.
Note:
The text was updated successfully, but these errors were encountered: