-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages section “page” property does not to work #6735
Comments
SummaryThis issue happens for two reason:
What should we do? Should we also clear localStorage when the session is ended (logged out) or should we always prioritize the defined |
I would prefer always landing on the defined page, not only on each new session. At least that’s what this option means to me, judging from the docs. It led to confusion multiple times both for me and clients who use Kirby. |
Description
If I use the the
page: 1
option on a sectiontype: pages
, it does not have any effect. No matter if I reload the panel, switch to another page and come back, or log out and in again—the localStorage item (eg.kirby$pagination$/pages/entries/entries
with a value of3
) will be saved and I will land on the page where I previously left off.In the docs, it says “Sets the default page for the pagination. This will overwrite default pagination.” What is the default pagination? Am I understanding this property wrong or does it actually not work?
Looking at the kirby source in
kirby/config/sections/pages.php
Lines 12 to 24 in eb47158
and also in
kirby/config/sections/pages.php
Lines 316 to 336 in eb47158
there does not seem to be anything about the
page
option. Or should it be included in thepagination
prop? Also in the Vue Component (and the ModelsSection.vue) there is not a line about this.Expected behavior
The pages section should reset to the given page after a reload, changing pages or logging out and in again. So on each visit, so to say, it should start whatever I set the
page
option to.To reproduce
type: pages
sectionpage
option to1
Your setup
Kirby Version
4.4.1
Your system (please complete the following information)
The text was updated successfully, but these errors were encountered: