Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting doesn't work as expected if some pages have fixed nums #6595

Open
tobimori opened this issue Aug 2, 2024 · 10 comments · Fixed by #6609
Open

Sorting doesn't work as expected if some pages have fixed nums #6595

tobimori opened this issue Aug 2, 2024 · 10 comments · Fixed by #6609
Assignees
Labels
needs: information ❓ Requires more information to proceed needs: replication 🔬 Requires a sample to reproduce the issue

Comments

@tobimori
Copy link
Contributor

tobimori commented Aug 2, 2024

Description

I want a specific page template to have num: 0 (and stay at the start). All other templates should be sortable as usual.

CleanShot.2024-08-02.at.11.41.56.mp4

Expected behavior
I'd not be able to sort the page with fixed num and when sorting other pages, they shouldn't jump when let go but stay at their expected position.

This can be partly treated as enhancement, however I'm still adding this as an issue. In my opinion, sorting should rather be disabled than allowing this buggy behaviour to avoid confusion.

Your setup

Kirby Version 4.3

@distantnative
Copy link
Member

@tobimori Are for you the following parts the same:

  • The page that has num: 0 in its template is actually never sortable itself (in no layout)
  • With card, list and cardlets layout, I can also not drag any other (sortable) page above the num: 0 page (as one would want/expect)
  • Only with the table layout, I can suddenly drag a sortable row above the num: 0 row (as in your video).

@tobimori
Copy link
Contributor Author

With card, list and cardlets layout, I can also not drag any other (sortable) page above the num: 0 page (as one would want/expect)

I can drag them above it, and then they jump to the second position (as seen in the video).

@distantnative
Copy link
Member

@tobimori but the video is in table layout

@tobimori
Copy link
Contributor Author

Sorry, my mistake 🤦 I haven't tested other layouts.

@distantnative
Copy link
Member

Would be great if you could, just to be sure that we've narrowed down the extend of the issue correctly.

@distantnative distantnative self-assigned this Aug 11, 2024
@distantnative distantnative linked a pull request Aug 11, 2024 that will close this issue
5 tasks
@distantnative
Copy link
Member

@tobimori or please test if this is solved for your case with 4.4.0-rc.1

@distantnative distantnative added the needs: information ❓ Requires more information to proceed label Aug 15, 2024
@tobimori
Copy link
Contributor Author

I have this issue on 4.4.0-rc.1 now with the list layout as well.

@distantnative
Copy link
Member

@tobimori could you please share your blueprint? Thanks!

@tobimori
Copy link
Contributor Author

What do you need exactly? This was in a different project with the same pattern (num: 0) on one blueprint type only. I can also share the whole project privately if that helps.

@distantnative
Copy link
Member

That would help as well. Currently, I cannot reproduce that this would happen in the list layout now, neither in the table layout anymore.

Setup:

  • Pages section
  • Allows 2 templates
  • One template set num: 0, one page with this template and folder name starting with 0_
  • One template without num, 3 pages with this template and folder names starting wit a normal order number 1_, 2_...
  • I can sort the three pages, but I cannot drag them above the 0_ page which remains unsortable
  • Both in list as well as table layout

@distantnative distantnative added the needs: replication 🔬 Requires a sample to reproduce the issue label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: information ❓ Requires more information to proceed needs: replication 🔬 Requires a sample to reproduce the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants