Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: no event is fired if window.opener does not exist #157

Open
rolznz opened this issue Nov 14, 2023 · 1 comment
Open

Bug: no event is fired if window.opener does not exist #157

rolznz opened this issue Nov 14, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rolznz
Copy link
Contributor

rolznz commented Nov 14, 2023

I think we should fire to both the window and window.opener. This will work with React Native / cases where the new app page is opened from a parent window and not a popup.

See https://github.com/getAlby/nostr-wallet-connect/blob/main/views/apps/create.html#L76
@rolznz rolznz added the good first issue Good for newcomers label Nov 14, 2023
@rolznz
Copy link
Contributor Author

rolznz commented Nov 14, 2023

A temporary hack for consumers is to execute this line in the window that opens the new NWC connection page:
window.opener = window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolznz