-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: maxRetries will always try at least twice #640
Comments
For some reason, in v5, maxAttempts was renamed to maxRetries, but the behaviour wasn't changed, so Note that the number of attempts is not the same as the number of tries. One try may contain three attempts if it has to try three different ports. |
The later part can be addressed by using the |
I think slightly modifying the log output to clarify what it has done might save any misunderstanding. Something like |
Describe the bug
When I set maxRetries to 1 or 0 gamedig will still retry at least twice sometimes 3 times.
Steps To Reproduce
set maxRetries to 1 or 0 and see at least 2 failed attempts
Expected behavior
gamedig should try only once
Error: Failed all 3 attempts
The text was updated successfully, but these errors were encountered: