Flatten command field types for the jsonpacker #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 83.70% 83.71%
=======================================
Files 34 34
Lines 3485 3487 +2
=======================================
+ Hits 2917 2919 +2
Misses 568 568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for your contribution, we will look at the changes later. But for now, could you maybe create an issue and attach it to this PR? It would make keeping track of issues a lot easier for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flattens the field type
commandin the JSON packer and fixes #132.Currently the
dissect.targetproject is inconsistent in using the same field namecommandand the new field typecommand. This patch makes it possible to upload and aggregate on different records in Elasticsearch with the field namecommandand differing field types.For example, see
RunKeysPlugin.runkeysandPowerShellHistoryPlugin.powershell_history.You could argue (and we agree) that this should be fixed in
dissect.targetas allRecordDescriptors currently using("string", "command")should perhaps use the newcommandrecord type. That makes sense to do in the long run. Perhaps a field calledfullcould be added to the standard output of thecommandfieldtype dict to still be able to index the full, original, command.Historically the
commandfield type introduced a backwards incompatible change into dissect. This PR fixes that inconsistency.