Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] specparam v2.0.0 #193

Closed
3 tasks done
ryanhammonds opened this issue Feb 12, 2021 · 9 comments
Closed
3 tasks done

[WIP] specparam v2.0.0 #193

ryanhammonds opened this issue Feb 12, 2021 · 9 comments
Labels
2.0 Targetted for the specparam 2.0 release.

Comments

@ryanhammonds
Copy link
Contributor

ryanhammonds commented Feb 12, 2021

The next major release of the 'fooof' tool will update the name of the tool to 'specparam' (for spectral parameterization).

Plan for migrating from fooof to specparam.

Naming

API

  • Flexibility for other aperiodic/periodic fit functions (i.e skewed gaussian, double exponential, gamma, etc).
    • The plan for this is to be post specparam release to speed up transition.

NOTE: Updated by Tom, and some milestones moved, as we organize updates across versions (1.1 / 2.0 / >2.0)

@ryanhammonds
Copy link
Contributor Author

@TomDonoghue everything should be complete here (after review + merge), except the flexible fit func (#194) PR and the final naming changes.

@ryanhammonds
Copy link
Contributor Author

@voytek This is the issue that can be used for the changelog and progress report.

@ryanhammonds ryanhammonds changed the title [WIP] NAPP v1.0.0 [WIP] specparam v1.0.0 Apr 6, 2021
@TomDonoghue
Copy link
Member

Thanks for the organization and work on all this Ryan! With the name update in progress (#205) this should now all be done / in process, so I'm going to close this issue now.

@danieltomasz
Copy link

Is there any timeline for specparam release? So the best practice would be now to refer to the package as specparam instead of fooof while writing a new manuscript?

@TomDonoghue
Copy link
Member

Hey @danieltomasz - there isn't an exact timeline layed out - but hopefully soon (I hope to finish and release the new version as SpecParam in the next month). Note that the model isn't changing, so practically the new SpecParam will be equivalent to the current fooof. In a manuscript, you can refer to either name, or I would perhaps write something like: "spectral parameterization (v.1.0.0; REF) was used to..." - I don't think it matters too much.

@TomDonoghue TomDonoghue reopened this Jul 30, 2021
@TomDonoghue TomDonoghue changed the title [WIP] specparam v1.0.0 [WIP] specparam v2.0.0 Jul 30, 2021
@TomDonoghue TomDonoghue added the 2.0 Targetted for the specparam 2.0 release. label Sep 28, 2021
@danieltomasz
Copy link

danieltomasz commented Jul 22, 2022

@TomDonoghue @ryanhammonds any timeline for the release? Does the released version will be much different from the current main branch? Algorithm will stay the same, but there are some API changes

@TomDonoghue
Copy link
Member

TomDonoghue commented Jul 22, 2022

Hey @danieltomasz - ooops / wow, I can't believe how long it has been already! The delay is my fault - as I'm in a new position, I got distracted from finishing the code work here.

The new version, in terms of the naming updates, is pretty close to being done over on this branch:
https://github.com/fooof-tools/fooof/tree/name
^For this, which we intend to be the new release, there are a lot of name changes, but no core algorithm changes. The plan is to release a specparam version that should match the algorithm of the previous fooof release, and then build from there for any future algorithm changes. Practically this means people should be able to continue using the current fooof release, or pull from the specparam branch and start with the new API, without having any important differences in algorithm / results.

In terms of timeline - I don't want to over-promise with any particular date, but I can note we are close (a couple of weeks or so) from releasing the main new code project from my current position, at which point I plan to dedicate my code work time back to this project (and neurodsp).

@danieltomasz
Copy link

danieltomasz commented Nov 16, 2022

Sorry for delayed reply :) I can understand delay :) but still anyway await new release (in its proper time :) )
My question after looking into time of last changes: are the important changes from the main backported into name branch ?
I would like to propose one thing - maybe use the major version number as a branch name ( specparam2.0 and fooof1.0 or the same way as mne is doing)?

@TomDonoghue
Copy link
Member

This issue is effectively outdated, as the main branch is now updated to specparam2.0. There are still ongoing updates to be included in 2.0 as open PRs, but those are beyond what's discussed in this issue - so I'm going to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Targetted for the specparam 2.0 release.
Projects
None yet
Development

No branches or pull requests

3 participants