Give flyte binary cluster role permission to create service accounts #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Sreenivas <46835608+shreyas44@users.noreply.github.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5579 +/- ##
==========================================
+ Coverage 33.99% 35.90% +1.91%
==========================================
Files 1135 1301 +166
Lines 102001 109396 +7395
==========================================
+ Hits 34678 39284 +4606
- Misses 63719 66016 +2297
- Partials 3604 4096 +492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Congrats on merging your first pull request! 🎉 |
3 tasks
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Shreyas Sreenivas <46835608+shreyas44@users.noreply.github.com> Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
eks-starter.yamlfile was failing for the above reasonWhat changes were proposed in this pull request?
Give the flyte binary cluster role permissions to create new service accounts.
How was this patch tested?
Tested on an internal kubernetes cluster.
Screenshots
Before:
After:
