Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for vite #23

Open
rubys opened this issue May 24, 2023 · 4 comments
Open

Better support for vite #23

rubys opened this issue May 24, 2023 · 4 comments

Comments

@rubys
Copy link
Contributor

rubys commented May 24, 2023

See: https://community.fly.io/t/vite-not-found-on-ci-deploy-from-github/13064

Best solution is likely to install nginx and copy the build output to /usr/share/nginx/html.

@MichaelDeBoey
Copy link
Collaborator

As the Remix team is working on the transition to Vite (instead of ESBuild), it would be awesome if this could be supported 😍

@rubys
Copy link
Contributor Author

rubys commented Oct 22, 2023

I'd need to know a bit more as there are so many ways to use Vite. For example, if you look at the community.fly.io link from May you will see that node isn't needed at all during runtime for that example, but undoubtedly for Remix node is needed.

If npm run build produces static assets, and those assets are served using express or equivalent, there may not need to be any change at all to the Dockerfile.

@MichaelDeBoey
Copy link
Collaborator

undoubtedly for Remix node is needed

Remix also supports Cloudflare (obviously not in scope of this lib), Bun & Deno

@rubys
Copy link
Contributor Author

rubys commented Oct 22, 2023

despite the name, dockerfile-node supports bun. I haven't tried Deno yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants