Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

age report URL still not redacted #112

Open
FiloSottile opened this issue Mar 29, 2024 · 4 comments
Open

age report URL still not redacted #112

FiloSottile opened this issue Mar 29, 2024 · 4 comments

Comments

@FiloSottile
Copy link

FiloSottile/age#550, FiloSottile/age#551, FiloSottile/age#552, FiloSottile/age#553, FiloSottile/age#556, FiloSottile/age#557, and FiloSottile/age#558 were all filed after #19 was closed, and a couple show transcripts with the age report URL still.

I must insist, this time with some annoyance, that you redact the age report URL from your claim script outputs.

@folex
Copy link
Member

folex commented Mar 29, 2024

Hello! First of all, thank you for all the work on age! 🙏

I'm so sorry it still gets channeled to you. I understand the annoyance it should generate. We will fix it ASAP!

@folex
Copy link
Member

folex commented Mar 29, 2024

This should help #113

I'll give it a few tests to make sure it never contains link to your report page 🙏 And after review, we'll merge it.

Sorry for the trouble!

@folex
Copy link
Member

folex commented Mar 29, 2024

The only place left that I'm not sure how to address is our small web page, on the screenshot.

We advise users to run age directly, and in case of an error it will obviously print the native Age error, with the report URL in it.

claim through web

I have reviewed the issues you linked, and it seems there were no reports related to this web page approach. I guess that's because it makes it impossible to specify wrong SSH key.

So, I suggest to see if any reports regarding direct Age call will appear. If they will, then I guess we can have a small bash wrapper that would sed the URL out of the age error.

I'm hesitant to do that right away, even 1 bash script is already too much when it comes to accessing private keys :) Users calling age directly sounds so much better.

What do you think?

@folex
Copy link
Member

folex commented Apr 3, 2024

We have merged the PR, hopefully that helps 🙏

I won't close the issue for now, so that we all understand it might be only a partial solution, and can continue the discussion here.

Thank you for reaching out, and sorry again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants