New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in electron+webpack #19

Closed

chinesedfan opened this issue Apr 9, 2018 · 1 comment

Contributor

chinesedfan commented Apr 9, 2018

electron provides a module module like node.js, so it differs with the pure browser environment described in #18.

But webpack's modules do not have module.parent(Refer webpack3). Can we add an undefined check for the following line?

parent.children && parent.children.splice(parent.children.indexOf(m), 1);

The text was updated successfully, but these errors were encountered:

Owner

floatdrop commented Apr 9, 2018

@chinesedfan sure, can you make a PR?

chinesedfan mentioned this issue

Handle if module.parent is undefined #20

Merged

floatdrop closed this as completed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment