Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] allow deleting the default color #979

Open
omesh-omg opened this issue Jul 26, 2024 · 2 comments
Open

[SDK] allow deleting the default color #979

omesh-omg opened this issue Jul 26, 2024 · 2 comments
Labels
enhancement New feature or request sdk Software development kit theme builder app Theme Builder application

Comments

@omesh-omg
Copy link
Contributor

omesh-omg commented Jul 26, 2024

Problem/Concern : cannot delete default color

Required in progress with the EPIC - 820 #820

  • colorPalette.removeColor(colorName) using this to delete the default color it creates error at runtime
  • default color : according SDK is the color which was added to the palette for the first time.

Uncaught runtime errors:
×
ERROR
You can not remove the default color (Color Palette)
at ColorPalette.removeColor (http://localhost:3000/static/js/bundle.js:90920:13)
at handleMenuButtonDeleteColor (http://localhost:3000/static/js/bundle.js:5485:32)
at onClick (http://localhost:3000/static/js/bundle.js:5693:40)
at HTMLUnknownElement.callCallback (http://localhost:3000/static/js/bundle.js:172881:18)
at Object.invokeGuardedCallbackDev (http://localhost:3000/static/js/bundle.js:172925:20)
at invokeGuardedCallback (http://localhost:3000/static/js/bundle.js:172982:35)
at invokeGuardedCallbackAndCatchFirstError (http://localhost:3000/static/js/bundle.js:172996:29)
at executeDispatch (http://localhost:3000/static/js/bundle.js:177139:7)
at processDispatchQueueItemsInOrder (http://localhost:3000/static/js/bundle.js:177165:11)
at processDispatchQueue (http://localhost:3000/static/js/bundle.js:177176:9)

Proposed Solution

@omesh-omg omesh-omg added sdk Software development kit enhancement New feature or request theme builder app Theme Builder application labels Jul 26, 2024
@aaronreed708
Copy link
Contributor

Do you mean that the color is the first color ever added to the palette? Or is it because you are trying to delete the last and only color left in the palette?

@omesh-omg
Copy link
Contributor Author

It is the first color added to the palette .

If it is last color we will deny the user that it is not possible to delete.we don't have to use SDK at all in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdk Software development kit theme builder app Theme Builder application
Projects
Status: High Priority
Development

No branches or pull requests

2 participants