Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to group and ff 0.13 #1653

Closed
vmx opened this issue Dec 8, 2022 · 1 comment
Closed

Upgrade to group and ff 0.13 #1653

vmx opened this issue Dec 8, 2022 · 1 comment

Comments

@vmx
Copy link
Contributor

vmx commented Dec 8, 2022

Description

The group and ff crates are a central piece. They are used in lots of our dependencies. As they also define traits, one need to make sure that that the whole dependency tree has the same version, else it can easily come to build failures.

Upgrading those two crates always mean a new breaking change release for all crates that update.

Timing: Currently we are not blocked on anything as for the Halo2 work we work of branches anyway. One reason to do it sooner rather then later would be to get neptune of their pasta_curves fork. As there are already breaking changes planned for group, it might make sense to wait and see if we could even skip one upgrade cycle.

Acceptance criteria

The whole dependency us upgraded to v0.13 of group and ff.

Risks + pitfalls

It needs quite a bit of coordination as several crates are involved.

Where to begin

Here are the crates that need to be updated. It's in the order that makes sure you can do the upgrade, as some depend on each other.

  1. https://github.com/filecoin-project/blstrs
  2. https://github.com/filecoin-project/bls-signatures
  3. https://github.com/filecoin-project/ec-gpu
  4. https://github.com/filecoin-project/bellperson
  5. https://github.com/filecoin-project/neptune
  6. https://github.com/filecoin-project/rust-fil-proofs
@vmx
Copy link
Contributor Author

vmx commented May 26, 2023

This has been merged with #1691.

@vmx vmx closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant